Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build workflow to add back osx-arm64 #6157

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update build workflow to add back osx-arm64 #6157

merged 1 commit into from
Dec 4, 2024

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Nov 13, 2024 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#2786

Description

"In macOS Sequoia, users will no longer be able to Control-click to override Gatekeeper when opening software that isn’t signed correctly or notarized," the brief note reads. "They’ll need to visit System Settings > Privacy & Security to review security information for software before allowing it to run."

https://arstechnica.com/gadgets/2024/09/macos-15-sequoia-the-ars-technica-review/#page-17

x64 would provide same UX as arm64 build
So add arm64 back for macOS

Screenshots

image

Testing

If you have macOS you can download from
https://github.com/PikachuEXE/FreeTube/actions/runs/11808637281
Run xattr -dr com.apple.quarantine <path>

Desktop

I tested in

  • OS: macOS
  • OS Version: 13.7.1 (22H221)
  • FreeTube version:

Additional context

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 13, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 13, 2024 01:20
@ChunkyProgrammer
Copy link
Member

https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/release.yml should be updated as well.

@PikachuEXE
Copy link
Collaborator Author

Should we do that after releasing 0.22.1? Asking for opinion

@absidue
Copy link
Member

absidue commented Nov 21, 2024

If we decide to release a 0.22.1 then yes we should wait until afterwards, but then this entire pull request should really wait, so that both workflows are updated at the same time.

@PikachuEXE PikachuEXE mentioned this pull request Nov 22, 2024
Open
@PikachuEXE PikachuEXE added the DO NOT MERGE UNTIL AFTER RELEASE Do not merge before the next release as this is not a bug fix label Nov 25, 2024
@PikachuEXE PikachuEXE force-pushed the build/add-mac-arm64 branch 2 times, most recently from ed8846d to fe7ca72 Compare November 25, 2024 07:50
@PikachuEXE
Copy link
Collaborator Author

PikachuEXE commented Nov 25, 2024 •
edited
Loading

Now in addition to restoring osx-arm64, asset file names for mac-x64 also updated to include suffix x64

Update 1: Ignore above, path not controlled by us (yet?)

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 3, 2024 •
edited
Loading

  • Whats preventing this from merge? We decided on going the 0.23.0 route so DO NOT MERGE UNTIL AFTER RELEASE can be removed right?
  • Also why doesnt it close the issue linked in the PR body?

@PikachuEXE
Copy link
Collaborator Author

That issue is for https://freetubeapp.io/#download
This PR does not change that website

I have no idea what next release version is feel free to remove the red tag and approve if 0.23 is the next version
I just add it when 0.22.1 seemed to be a thing

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the DO NOT MERGE UNTIL AFTER RELEASE Do not merge before the next release as this is not a bug fix label Dec 4, 2024
@FreeTubeBot FreeTubeBot merged commit 0e44e6b into FreeTubeApp:development Dec 4, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 4, 2024
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
@PikachuEXE @Soham456
* Update build workflow to add back osx-arm64 (FreeTubeApp#6157)
1c9f7dc
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the build/add-mac-arm64 branch December 5, 2024 18:30
jlvivero pushed a commit to jlvivero/FreeTube that referenced this pull request Dec 7, 2024
@PikachuEXE
* Update build workflow to add back osx-arm64 (FreeTubeApp#6157)
c6ab6f5
OothecaPickle added a commit to OothecaPickle/FreeTube that referenced this pull request Dec 14, 2024
@OothecaPickle
Revert "* Update build workflow to add back osx-arm64 (FreeTubeApp#6157…
68e432d 
…)"

This reverts commit 0e44e6b.
@fraschm1998

This comment was marked as resolved.

Sign in to view
@PikachuEXE
Copy link
Collaborator Author

@fraschm1998 Please check file on dev branch on current repo before giving just claim
https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml

If you are talking about the commit(s) made on a fork, they are irrelevant for this repo
image

Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PikachuEXE @ChunkyProgrammer @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @fraschm1998 @FreeTubeBot